代码优化

Mall.Module.Product/OrderModule.cs

@@ -2685,7 +2685,7 @@ namespace Mall.Module.Product
                 coupon = new
                 {
                     enabled = true,
-                    use = CouponsMoney > 0 && demodel.User_Coupon_Id > 0 ? true : false,
+                    use = CouponsMoney > 0 && demodel.User_Coupon_Id > 0,
                     coupon_discount = CouponsMoney,
                     user_coupon_id = CouponsMoney > 0 ? demodel.User_Coupon_Id ?? 0 : 0
                 },
@@ -14038,16 +14038,13 @@ namespace Mall.Module.Product
         {
             var omodel = new RB_Goods_Order();
             int OrderId = 0;
-            var dmodel = new RB_Goods_OrderDetail();
+            RB_Goods_OrderDetail dmodel;
             if (demodel.OrderDetailId > 0)
             {
                 dmodel = goods_OrderDetailRepository.GetEntity(demodel.OrderDetailId);
                 if (dmodel == null) { return false; }
                 OrderId = dmodel.OrderId ?? 0;
                 if (dmodel.IsComment == 1) { return false; }
-                //omodel = goods_OrderRepository.GetEntity(OrderId);
-                //if (omodel == null) { return false; }
-                //if (omodel.OrderStatus != OrderStatusEnum.Received) { return false; }
             }
             bool flag = goods_CommentRepository.Insert(demodel) > 0;
             if (flag)
@@ -14959,7 +14956,7 @@ namespace Mall.Module.Product
                 {
                     item.OrderId = OrderId;
                     //插入订单明细表
-                    int detailId = goods_OrderDetailRepository.Insert(item, trans);
+                    goods_OrderDetailRepository.Insert(item, trans);
                 }
                 //记录日志
                 goods_LogRepository.Insert(new RB_Goods_Log()

Mall.WebApi/Controllers/Education/AppletEducationController.cs

@@ -238,7 +238,7 @@ namespace Mall.WebApi.Controllers.Education
             query.TenantId = userInfo.TenantId;
             query.MallBaseId = userInfo.MallBaseId;
             query.UserId = userInfo.UserId;
-            RB_Education_Coupon_Extend resultModel = new RB_Education_Coupon_Extend();
+            RB_Education_Coupon_Extend resultModel;
             if (query.TriggerType == 2)
             {
                 query.TriggerType = 4;